Products Onboarding: Support template products #8005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ecarrion
added
the
feature: products onboarding
Collaborator
You can test the changes from this Pull Request by:
|
rachelmcr
approved these changes
Nov 2, 2022
Contributor
rachelmcr
left a comment
rachelmcr
left a comment
There was a problem hiding this comment.
Nice idea! That shortcut makes a lot of sense for what we need right now. Looks good and tests well. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7949
Why
This PR makes sure that a template product can be used within the product form as it was manually populated by the merchant.
How
Instead of taking the long route and adding full auto-draft support to our product form module, I've taken a shortcut where after getting a template product, which has an
auto-draftstatus, the app removes that product identity (id, name and status) so it's treated like a new product but with all the necessary content prefilled.We can evaluate later if full auto-draft support is needed.
Demo
auto-draft-support.mov
Testing Steps
RELEASE-NOTES.txtif necessary.